-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #101928
Rollup of 8 pull requests #101928
Conversation
This rule originated in 7669f04, to override the default, massive left margin that content used to accommodate the sidebar: https://github.com/rust-lang/rust/blob/7669f04fb0ddc3d71a1fb44dc1c5c00a6564ae99/src/librustdoc/html/static/main.css#L307-L309 This massive left margin doesn't exist any more. It was replaced with a flexbox-based sidebar layout in 135281e.
This rule originated in 7669f04, to override the default, limited line-width that makes sense for prose, but doesn't make sense for code (which typically uses hard-wrapped lines): https://github.com/rust-lang/rust/blob/7669f04fb0ddc3d71a1fb44dc1c5c00a6564ae99/src/librustdoc/html/static/main.css#L153 This line width limiter isn't applied to the `<div class="content">` node any more. It's been moved to a separate wrapper `<div>` that used to be called `main-inner` (in 135281e) but is now called `width-limiter` (since d7528e2).
This commit does three things: * First, it passes --cfg=bootstrap on stage 0 for rustdoc invocations on proc_macro crates. This mirrors what we do already for rustc invocations of those, and is needed because cargo doesn't respect RUSTFLAGS or RUSTDOCFLAGS when confronted with a proc macro. * Second, it marks the bootstrap config variable as expected. This is needed both on later stages where it's not set, but also on stage 0, where it is set. * Third, it adjusts the comment in the rustc wrapper to better reflect the reason why we set the bootstrap variable as expected: due to recent changes, setting it as expected is also required even if the cfg variable is passed: ebf4cc3 .
…=tmandry Adding Fuchsia zxdb debugging walkthrough to docs Adding `zxdb` docs to walkthrough to show debugging steps
…tests, r=tmandry Adding needs-unwind arg to applicable compiler ui tests Adding `needs-unwind` arg to applicable compiler ui tests
…ng-diags-migration, r=davidtwco Update `symbol_mangling` diagnostics migration Addresses comments raised in rust-lang#100831. r? `@eddyb` `@davidtwco`
…r=lcnr More simple formatting
…triddle Remove some unused CSS rules Since we now have list of items for the ones on the page, we don't need the CSS rules anymore in the sidebar (`.sidebar a`). As for the `.content` ones, they are used to highlight the items in the page (for definitions and others). Surprisingly enough, `method` and `tymethod` are all replaced with `fnname`. I also used this opportunity to remove these rules in `ayu.css`: ```css .stab.unstable {} h2, h3:not(.impl):not(.method):not(.type):not(.tymethod), h4:not(.method):not(.type):not(.tymethod) {} ``` In the second commit, I removed the `.block a.current*` CSS rules as they're overridden by `.sidebar a.current*` CSS rules. In the third commit I removed unneeded empty rules (that were there to satisfy the `--check-theme` option). cc ``@jsha`` r? ``@notriddle``
…, r=GuillaumeGomez rustdoc: remove no-op CSS on `.source .content` # `margin-left: 0` This rule originated in 7669f04, to override the default, massive left margin that content used to accommodate the sidebar: https://github.com/rust-lang/rust/blob/7669f04fb0ddc3d71a1fb44dc1c5c00a6564ae99/src/librustdoc/html/static/main.css#L307-L309 This massive left margin doesn't exist any more. It was replaced with a flexbox-based sidebar layout in 135281e. # `max-width: none` This rule originated in 7669f04, to override the default, limited line-width that makes sense for prose, but doesn't make sense for code (which typically uses hard-wrapped lines): https://github.com/rust-lang/rust/blob/7669f04fb0ddc3d71a1fb44dc1c5c00a6564ae99/src/librustdoc/html/static/main.css#L153 This line width limiter isn't applied to the `<div class="content">` node any more. It's been moved to a separate wrapper `<div>` that used to be called `main-inner` (in 135281e) but is now called `width-limiter` (since d7528e2).
… r=jsha rustdoc-json-types: Document that ResolvedPath can also be a union r? rustdoc
…htriplett Pass --cfg=bootstrap for rustdoc for proc_macro crates This PR does three things: * First, it passes --cfg=bootstrap on stage 0 for rustdoc invocations on proc_macro crates. This mirrors what we do already for rustc invocations of those, and is needed because cargo doesn't respect RUSTFLAGS or RUSTDOCFLAGS when confronted with a proc macro. * Second, it marks the bootstrap config variable as expected. This is needed both on later stages where it's not set, but also on stage 0, where it is set. * Third, it adjusts the comment in the rustc wrapper to better reflect the reason why we set the bootstrap variable as expected: due to recent changes, setting it as expected is also required even if the cfg variable is passed: ebf4cc3 .
@bors r+ rollup=never p=8 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR: previous master: c524c7dd25 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (4a12d10): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Successful merges:
symbol_mangling
diagnostics migration #101782 (Updatesymbol_mangling
diagnostics migration).source .content
#101911 (rustdoc: remove no-op CSS on.source .content
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup